Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update meta/config to publish Windows wheels #296

Merged
merged 2 commits into from
May 22, 2024
Merged

Update meta/config to publish Windows wheels #296

merged 2 commits into from
May 22, 2024

Conversation

dataflake
Copy link
Member

@dataflake dataflake commented May 18, 2024 •
edited
Loading

Fixes #295

Update to an (unreleased) meta/config template that adds a publishing step for Windows wheels when git tags are set.

@dataflake dataflake requested a review from icemac May 18, 2024 09:39
@icemac icemac mentioned this pull request May 22, 2024
Closed
icemac
icemac approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes. Create a 6.4.post1 would probably be easier than adding the wheels to existing releases.

I can do this, if you want.

@dataflake dataflake merged commit e8ad972 into master May 22, 2024
59 of 60 checks passed
@dataflake dataflake deleted the config-with-c-code-template-761944d0 branch May 22, 2024 17:10
@dataflake
Copy link
Member Author

Thanks, go ahead and do that when you have a moment.

@dataflake dataflake mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wheel building process produces no Windows wheels
2 participants
@dataflake @icemac